fix: Added --api-proxy option to the sign command (#593)

bin/jpm

@@ -101,6 +101,8 @@ program
  "optional XPI to be signed. By default, an XPI will be built " +
  "from your working directory")
  .option("--timeout <milliseconds>", "time to wait for a signing result")
+ .option("--api-proxy <url>", "Optional proxy to use for all API requests." +
+ " Example: https://yourproxy:6000")
  .action(function(options) {
  signCmd(program, options);
  });

lib/sign.js

@@ -117,8 +117,9 @@ function sign(options, config) {
  apiKey: options.apiKey,
  apiSecret: options.apiSecret,
  apiUrlPrefix: options.apiUrlPrefix,
+ apiProxy: options.apiProxy || undefined,
  verbose: options.verbose,
- timeout: options.timeout || undefined,
+ timeout: options.timeout || undefined
  }).then(function(result) {
  if (typeof xpiInfo.cleanUp !== "undefined") {
  logger.debug("cleaning up XPI temp directory");

test/unit/test.sign.js

@@ -173,6 +173,19 @@ describe("sign", function() {
  }).catch(done);
  });
 
+ it("can configure a proxy", function() {
+ return runSignCmd({
+ cmdOptions: {
+ apiKey: "some-key",
+ apiSecret: "some-secret",
+ apiProxy: "some-proxy",
+ },
+ }).then(function() {
+ expect(signAddonCall.call[0].apiProxy)
+ .to.be.equal("some-proxy");
+ });
+ });
+
  it("passes custom XPI to the signer", function(done) {
  var mockXpiInfoGetter = new CallableMock({
  returnValue: when.promise(function(resolve) {