Added option to limit the number of explored states #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added option `--build:state limit <number>` which, if set, stops expanding new states once the given `<number>` of states has been found. This is useful for, e.g., debugging models that normally would be too large. Unexplored states get a label `"unexplored"` assigned to them. This even allows to calculate the probability to exit the fraction of the explored state space
sjunges
reviewed
Apr 13, 2024
| @@ -90,7 +90,8 @@ PrismNextStateGenerator<ValueType, StateType>::PrismNextStateGenerator(storm::pr | |||
| std::make_pair(this->program.getLabelExpression(expressionOrLabelAndBool.first.getLabel()), expressionOrLabelAndBool.second)); | |||
| } else { | |||
| // If the label is not present in the program and is not a special one, we raise an error. | |||
| STORM_LOG_THROW(expressionOrLabelAndBool.first.getLabel() == "init" || expressionOrLabelAndBool.first.getLabel() == "deadlock", | |||
| STORM_LOG_THROW(expressionOrLabelAndBool.first.getLabel() == "init" || expressionOrLabelAndBool.first.getLabel() == "deadlock" || | |||
There was a problem hiding this comment.
With now three special labels, it may make sense to write a helper function that does this check (I think I saw it somewhere above as well)
|
LGTM. One nitpicky comment :-) |
tquatmann
force-pushed
the
exploration-state-limit
branch
from
e4d3cea
to
136d317
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added option
--build:state limit <number>which, if set, stops expanding new states once the given<number>of states has been found.This is useful for, e.g., debugging models that normally would be too large.
If there are unexplored states, a label
"unexplored"is added and assigned to them. This even allows to calculate the probability to exit the fraction of the explored state space.Note: the "unexplored" label does not exist if all states are explored.