Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve MoveIt Servo tutorial with keyboard teleop instructions. #833

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tahsinkose
Copy link
Contributor

Description

This PR adds a keyboard teleop section to MoveIt servo tutorial. The video link refers to https://www.youtube.com/watch?v=BOcKcjQli3o

Needs:

@tahsinkose tahsinkose force-pushed the tahsin/improve-servo-tutorial branch from 5920c8f to 661c0b2 Compare October 27, 2024 19:42
Copy link
Member

@AndyZe AndyZe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Comment on lines 154 to 155


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@@ -120,6 +120,39 @@ The ``moveit_servo/config`` folder contains two examples of converting `SpaceNav

``spacenav_cpp.launch`` launches a C++ node that does the same thing but with less latency. We do not plan to accept C++ pull requests for more controller types because there is a lot of overhead involved in supporting them.

Configuring Keyboard as a Control Device
------------------------------------------------------
Assuming you are in ``~/ws_moveit`` folder already, ``cd`` to ``src/universal_robot`` and checkout the latest ``noetic-devel`` branch with ``git checkout noetic-devel``. After this, you should have a ``ur5_moveit_tutorials`` package under ``universal_robot`` folder. Finally:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a ur5_moveit_tutorials package here: https://github.com/ros-industrial/universal_robot/tree/noetic-devel

Am I looking in the wrong place?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. The package exists on my fork. I also have a PR for that -> ros-industrial/universal_robot#688. Unfortunately there isn't activity since I've created that PR.

@tahsinkose tahsinkose force-pushed the tahsin/improve-servo-tutorial branch from 5f1a68b to c8c121d Compare November 3, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants