GH-9 added dynamic screenshot folder #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moved default folder to local project
|
not sure what's going on in the main niffy repo so i'll continue to work here |
|
for segmentio#9 |
|
This PR looked great. I'm guessing this hasn't actually been released though? |
|
Sure has! I reached out to the niffy team and they seemed uninterested, so I published under a new name (keeping with the nightmare theme ofc ^^) I have 3 (Iirc) PRs open on niffy. This is niffy master with the PRs merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
had to change many
pathvariables topngPathdue to now importingpathfrom node