Max reconnect attempts #247
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harlov
force-pushed
the
max_reconnect_attempts
branch
3 times, most recently
from
d8d852d
to
71c5a59
Compare
decaz
reviewed
Sep 12, 2019
decaz
reviewed
Sep 12, 2019
harlov
force-pushed
the
max_reconnect_attempts
branch
from
71c5a59
to
af6aead
Compare
decaz
reviewed
Sep 12, 2019
harlov
force-pushed
the
max_reconnect_attempts
branch
from
af6aead
to
e95bec8
Compare
harlov
force-pushed
the
max_reconnect_attempts
branch
from
e95bec8
to
d95a3cc
Compare
harlov
force-pushed
the
max_reconnect_attempts
branch
from
d95a3cc
to
4b940c2
Compare
|
@harlov please rebase this branch against master. |
dizballanze
reviewed
Feb 14, 2020
| @@ -40,6 +40,10 @@ class QueueEmpty(AMQPError, asyncio.QueueEmpty): | |||
| pass | |||
|
|
|||
|
|
|||
| class MaxReconnectAttemptsReached(Exception): | |||
There was a problem hiding this comment.
Maybe, this class should be a subclass of ConnectionError
|
Any interest in moving this one ahead? I can help rebasing/testing if needed, but only if maintainers have interest in this feature. In my use case I need to stop a service if I lose connection (it will respawn later with correct parameters). But anything around adjusting the URL to reconnect could be useful too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adds a limit for reconnect attempts. It's useful in case then connect parameters have changed and we need gracefully shutdown and re-init client.