opt filtermanager 'onContinueReading' performance #1933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doujiang24
reviewed
Jan 17, 2022
| @@ -64,3 +64,5 @@ require ( | |||
| ) | |||
|
|
|||
| replace github.com/envoyproxy/go-control-plane => github.com/envoyproxy/go-control-plane v0.9.4 | |||
|
|
|||
| replace mosn.io/api => ../mosn-api | |||
There was a problem hiding this comment.
should not push these local changes.
|
|
||
| buf := fm.conn.GetReadBuffer() | ||
| func (fm *filterManager) onContinueReading(previousIndex int, buf buffer.IoBuffer) { |
There was a problem hiding this comment.
Suggested change
| func (fm *filterManager) onContinueReading(previousIndex int, buf buffer.IoBuffer) { | |
| func (fm *filterManager) onContinueReading(index int, buf buffer.IoBuffer) { |
maybe we can just use index here? It looks more simpiler.
| //fm.conn.Write("your data") | ||
| return | ||
| } | ||
| for ; index < len(fm.upstreamFilters); index++ { |
There was a problem hiding this comment.
I'm not sure if it is safe to skip checking uf.initialized here.
@taoyuanyuan @nejisama may confirm it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues associated with this PR
#1932
Solutions
You should show your solutions about the issues in your PR, including the overall solutions, details and the changes. At this time, Chinese is allowed to describe these.
UT result
Unit Test is needed if the code is changed, your unit test should cover boundary cases, corner cases, and some exceptional cases. And you need to show the UT result.
Benchmark
If your code involves the processing of every request, you should give the Benchmark Result.
Code Style
Goimportshas runGolintresult