Allow volume slider to change sink volume #1631
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When used in conjunction with sinks implementing GstStreamVolume (eg. pulsesink) volume slider uses native volume control.
Informatic
force-pushed
the
feature/output_volume
branch
from
a8d509d
to
45fdf40
Compare
|
Are there any plans on merging this? As a somewhat of a side-effect, this greatly reduces delay in volume changes on some platforms. |
jodal
added
C-enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds
audio/output_volumeconfiguration option, that makes volume slider change volume of gstreamer sink element. (eg. native pulseaudio volume) This is disabled by default to keep the behaviour backward compatible.This has been reported on https://discuss.mopidy.com/t/softwaremixer-and-pulseaudio/1644/9 and discussed on IRC a couple of weeks ago.
I'm publishing it here just to get some feedback from developers.
Right now, if there is no element implementing
GstStreamVolume, this will fallback to default behaviour (using intermediatevolumeelement), which might be slightly misleading (it should at least throw some sort of warning, unless it becomes enabled by default)