Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI licenses check #3062

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Fix CI licenses check #3062

merged 1 commit into from
Nov 28, 2024

Conversation

gonzamontiel
Copy link
Contributor

What does it do?

What important points reviewers should know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

@gonzamontiel gonzamontiel added B0-silent Changes should not be mentioned in any release notes ci Continuous Integration pipeline D3-trivial PR contains trivial changes in a runtime directory that do not require an audit labels Nov 28, 2024
Copy link
Contributor

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2248 KB (no changes) ✅

Moonbeam runtime: 2228 KB (no changes) ✅

Moonriver runtime: 2224 KB (no changes) ✅

Compared to latest release (runtime-3300)

Moonbase runtime: 2248 KB (+220 KB compared to latest release) ⚠️

Moonbeam runtime: 2228 KB (+232 KB compared to latest release) ⚠️

Moonriver runtime: 2224 KB (+232 KB compared to latest release) ⚠️

@RomarQ RomarQ marked this pull request as ready for review November 28, 2024 16:51
@RomarQ RomarQ requested review from a team as code owners November 28, 2024 16:51
Copy link
Contributor

Coverage Report

@@                     Coverage Diff                      @@
##           master   gonza/fix-verify-licenses     +/-   ##
============================================================
  Coverage   74.74%                      74.74%   0.00%     
  Files         369                         369             
  Lines       94269                       94269             
============================================================
  Hits        70453                       70453             
  Misses      23816                       23816             
Files Changed Coverage

Coverage generated Thu Nov 28 17:03:28 UTC 2024

@RomarQ RomarQ merged commit 58bb0c5 into master Nov 28, 2024
41 of 45 checks passed
@RomarQ RomarQ deleted the gonza/fix-verify-licenses branch November 28, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B0-silent Changes should not be mentioned in any release notes ci Continuous Integration pipeline D3-trivial PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants