Fix result of debug_traceBlockByNumber

[RomarQ]

What does it do?

Things missing @gonzamontiel:

• Add/fix tests

Example request:

curl https://trace.api.moonriver.moonbeam.network \
  -X POST \
  -H "Content-Type: application/json" \
  -d '{"jsonrpc": "2.0", "method": "debug_traceBlockByNumber", "params": ["0x6d6583", {"tracer": "callTracer"}], "id": 1}'

Actual result:

{
    "id": 1,
    "jsonrpc": "2.0",
    "result": [
        {
                "from": "0xc6392ad8a14794ea57d237d12017e7295bea2363",
                "gas": "0x4ce78",
                "gasUsed": "0x5208",
                "to": "0x8a0078ae40784f7920051f1c74718ea07c278e5d",
                "input": "0x",
                "value": "0x470de4df820000",
                "type": "CALL"
        },
       {
                "from": "0xc6392ad8a14794ea57d237d12017e7295bea2363",
                "gas": "0x4ce78",
                "gasUsed": "0x5208",
                "to": "0xd3ba12e13a662d296b50c68d94b54c86825bc643",
                "input": "0x",
                "value": "0x470de4df820000",
                "type": "CALL"
       }
    ]
}

Expected result example:

{
    "id": 1,
    "jsonrpc": "2.0",
    "result": [
        {
            "txHash": "0xd7fe78028fec35856f30bd447b4bbab658375e3ba1c2892d1ad0a4b5fd51de17",
            "result": {
                "from": "0xc6392ad8a14794ea57d237d12017e7295bea2363",
                "gas": "0x4ce78",
                "gasUsed": "0x5208",
                "to": "0x8a0078ae40784f7920051f1c74718ea07c278e5d",
                "input": "0x",
                "value": "0x470de4df820000",
                "type": "CALL"
            }
        },
        {
            "txHash": "0xaded92b859bf2d92e99608cf809925a82365e19cb2d64ddd958f85439e9be6d5",
            "result": {
                "from": "0xc6392ad8a14794ea57d237d12017e7295bea2363",
                "gas": "0x4ce78",
                "gasUsed": "0x5208",
                "to": "0xd3ba12e13a662d296b50c68d94b54c86825bc643",
                "input": "0x",
                "value": "0x470de4df820000",
                "type": "CALL"
            }
        }
    ]
}

[github-actions]

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2248 KB (no changes) ✅

Moonbeam runtime: 2228 KB (no changes) ✅

Moonriver runtime: 2224 KB (no changes) ✅

Compared to latest release (runtime-3300)

Moonbase runtime: 2248 KB (+220 KB compared to latest release) ⚠️

Moonbeam runtime: 2228 KB (+232 KB compared to latest release) ⚠️

Moonriver runtime: 2224 KB (+232 KB compared to latest release) ⚠️

[github-actions]

Coverage Report

@@                Coverage Diff                 @@
##           master   rq/add-tx-hash      +/-   ##
==================================================
- Coverage   74.74%           74.72%   -0.02%     
  Files         369              369              
+ Lines       94269            94295      +26     
==================================================
  Hits        70453            70453              
+ Misses      23816            23842      +26     

Files Changed	Coverage

Coverage generated Thu Nov 28 18:31:48 UTC 2024

[gonzamontiel]

I made some changes! but it's roughly what we spoke, looks good :)

[ahmadkaouk]

LGTM