-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PoC] Add ZkAuth precompile to Moonbase #2903
Draft
Agusrodri
wants to merge
24
commits into
master
Choose a base branch
from
zkAuth-precompile-poc
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Agusrodri
added
B7-runtimenoteworthy
Changes should be noted in any runtime-upgrade release notes
D5-nicetohaveaudit⚠️
PR contains trivial changes to logic that should be properly reviewed.
not-breaking
Does not need to be mentioned in breaking changes
labels
Aug 13, 2024
Coverage Report@@ Coverage Diff @@
## master zkAuth-precompile-poc +/- ##
=========================================================
+ Coverage 79.01% 79.03% +0.02%
+ Files 305 309 +4
+ Lines 88447 88593 +146
=========================================================
+ Hits 69878 70017 +139
+ Misses 18569 18576 +7
|
WASM runtime size check:Compared to target branchMoonbase runtime: 2604 KB (no changes) 🚨 Moonbeam runtime: 2236 KB (no changes) ✅ Moonriver runtime: 2232 KB (no changes) ✅ Compared to latest release (runtime-3300)Moonbase runtime: 2604 KB (+576 KB compared to latest release) 🚨 Moonbeam runtime: 2236 KB (+240 KB compared to latest release) Moonriver runtime: 2232 KB (+240 KB compared to latest release) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
B7-runtimenoteworthy
Changes should be noted in any runtime-upgrade release notes
D5-nicetohaveaudit⚠️
PR contains trivial changes to logic that should be properly reviewed.
not-breaking
Does not need to be mentioned in breaking changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Adds a PoC for the ZkAuth verification precompile.
This precompile, allows to verify a Risc0 zk-proof receipt by calling the
verifyProof
function, passing an encoded (ideally a Groth16-like) receipt as a parameter. If the verification succeeds, the receipt is then returned with the same format as it was originally received in the function parameter.