Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rocksDB weights #2786

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update rocksDB weights #2786

wants to merge 1 commit into from

Conversation

RomarQ
Copy link
Contributor

@RomarQ RomarQ commented Apr 29, 2024

What does it do?

This PR changes the rocksDb weights used in pallet frame_system based the storage benchmarks performed against 10M Moonbeam storage keys.

Previous values:

pub const RocksDbWeight: RuntimeDbWeight = RuntimeDbWeight {
	read: 25_000 * WEIGHT_REF_TIME_PER_NANOS,   // ~25 µs @ 200,000 items
	write: 100_000 * WEIGHT_REF_TIME_PER_NANOS, // ~100 µs @ 200,000 items
};

New values:

pub const RocksDbWeight: RuntimeDbWeight = RuntimeDbWeight {
	read: 41_742 * WEIGHT_REF_TIME_PER_NANOS,   // ~41 µs @ 200,000 items
	write: 81_283 * WEIGHT_REF_TIME_PER_NANOS, // ~81 µs @ 200,000 items
};

@RomarQ RomarQ added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Apr 29, 2024
@RomarQ RomarQ self-assigned this Apr 29, 2024
@RomarQ RomarQ added the not-breaking Does not need to be mentioned in breaking changes label Apr 29, 2024
@librelois
Copy link
Collaborator

@RomarQ can you merge master? I think we can merge this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants