-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Benchmark refresh #1350
Benchmark refresh #1350
Conversation
asset-manager is left out. Also we need to think what to do with crowdloan-rewards, perhaps update it too? |
You're right, there are some missing. I want this PR to include all the pallets from this repo and we can update others ( |
sounds good |
Updated I'm not sure what happened to the https://github.com/PureStake/nimbus/blob/main/pallets/author-slot-filter/src/weights.rs |
We probably need to pin crowdloan-rewards and nimbus to the new values right? I can push the commit that brings the new weights to nimbus 0.9.17 |
This PR #1337 includes the benchmark runtime api for author-slot-filter and it pints it to the new weights |
Edit 2: Yes, but that can happen separately. |
What does it do?
Updates benchmarks, notably generated from a new template file.
I expect this will fail CI because of trivial clippy/formatting issues. If possible, I'd like to fix this by excluding benchmarking
weight.rs
files from these checks because it will simplifybench-bot
workflows.