Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark refresh #1350

Merged
merged 9 commits into from
Mar 18, 2022
Merged

Benchmark refresh #1350

merged 9 commits into from
Mar 18, 2022

Conversation

notlesh
Copy link
Contributor

@notlesh notlesh commented Mar 15, 2022

What does it do?

Updates benchmarks, notably generated from a new template file.

I expect this will fail CI because of trivial clippy/formatting issues. If possible, I'd like to fix this by excluding benchmarking weight.rs files from these checks because it will simplify bench-bot workflows.

@notlesh notlesh added B0-silent Changes should not be mentioned in any release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit labels Mar 15, 2022
@girazoki
Copy link
Collaborator

asset-manager is left out. Also we need to think what to do with crowdloan-rewards, perhaps update it too?

@notlesh
Copy link
Contributor Author

notlesh commented Mar 16, 2022

asset-manager is left out. Also we need to think what to do with crowdloan-rewards, perhaps update it too?

You're right, there are some missing. I want this PR to include all the pallets from this repo and we can update others (crowdloan-rewards, nimbus) at the same time.

@girazoki
Copy link
Collaborator

sounds good

@notlesh
Copy link
Contributor Author

notlesh commented Mar 16, 2022

Updated crowdloan-rewards weights: moonbeam-foundation/crowdloan-rewards#54

I'm not sure what happened to the author-slot-filter (nimbus pallet) weights, but they look reasonable already (set_eligible has a single write recorded). So I'm not worried about it.

https://github.com/PureStake/nimbus/blob/main/pallets/author-slot-filter/src/weights.rs

@notlesh notlesh requested review from 4meta5 and girazoki March 17, 2022 16:51
@notlesh notlesh added the A0-pleasereview Pull request needs code review. label Mar 17, 2022
@girazoki
Copy link
Collaborator

We probably need to pin crowdloan-rewards and nimbus to the new values right? I can push the commit that brings the new weights to nimbus 0.9.17

@girazoki
Copy link
Collaborator

This PR #1337 includes the benchmark runtime api for author-slot-filter and it pints it to the new weights

@notlesh
Copy link
Contributor Author

notlesh commented Mar 18, 2022

We probably need to pin crowdloan-rewards and nimbus to the new values right? I can push the commit that brings the new weights to nimbus 0.9.17

Edit 2: Yes, but that can happen separately.

@notlesh notlesh merged commit cf32828 into master Mar 18, 2022
@notlesh notlesh deleted the notlesh-benchmark-changes branch March 18, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-pleasereview Pull request needs code review. B0-silent Changes should not be mentioned in any release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants