Overflow checker in initialize #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crystalin
reviewed
Aug 17, 2021
src/lib.rs
Outdated
| @@ -478,6 +480,8 @@ pub mod pallet { | |||
| // the native account has already some rewards in, we add the new ones | |||
| AccountsPayable::<T>::insert( | |||
| native_account, | |||
| // It should be safe not to use saturating_add here | |||
There was a problem hiding this comment.
I think it is better to still use the saturating_add in those cases no? Is there a cost to it ?
There was a problem hiding this comment.
A small one in terms of a couple of checks (the value being greater than the maximum). But I guess they are minimal, so I can also add it here
notlesh
reviewed
Aug 17, 2021
src/lib.rs
Outdated
| @@ -470,6 +470,8 @@ pub mod pallet { | |||
| claimed_reward: initial_payment, | |||
| }; | |||
|
|
|||
| // It should be safe not to use saturating_add here | |||
| // as we already checked before that these rewards do not overflow existing ones | |||
There was a problem hiding this comment.
You could consider using an assert here to express this. That may or may not be a good idea :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initialize_reward_vec did not have overflow checkers assuming this was democracy/sudo call based. I added these for consistency reasons with the rest of the pallet extrinsics