Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dotnet 7 migration #335

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Dotnet 7 migration #335

wants to merge 2 commits into from

Conversation

xaviergxf
Copy link

Hi Everyone,

Just migrating the project to .net 7

@jibal
Copy link

jibal commented Sep 1, 2023

Note the comment: "Make sure to update Directory.Build.targets too!"

@xaviergxf
Copy link
Author

Note the comment: "Make sure to update Directory.Build.targets too!"

Where is this comment? This file is currently empty

@jibal
Copy link

jibal commented Sep 4, 2023

The comment is line 8 of the file you modified--the line before your modification--and no, Directory.Build.targets is not currently empty, it's a duplicate of Directory.Build.Props

@xaviergxf
Copy link
Author

Directory.Build.targets is empty at main branch: https://github.com/mono/taglib-sharp/blob/main/Directory.Build.targets

@jibal
Copy link

jibal commented Sep 4, 2023

Ah, so it is ... I must have been looking at some other version. But then, the comment should be removed.

<ExeTargetFrameworks>net6.0;net472</ExeTargetFrameworks>
<LibTargetFrameworks>net6.0;netstandard2.0</LibTargetFrameworks>
<ExeTargetFrameworks>net7.0;net472</ExeTargetFrameworks>
<LibTargetFrameworks>net7.0;netstandard2.0</LibTargetFrameworks>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xaviergxf Thanks for the PR. Could I have you leave the net6.0 and add net8.0 instead. net8.0 is an LTS version and was just barely released.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated it on my side but there are now problems regarding deprecation of Formatter-based serialization. I don't understand why this is used...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh fun :) ok, I'll try and take a peek at this too.

@decriptor decriptor mentioned this pull request Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants