Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Adds test for stream_instance stream_config.tier #2289

Merged
merged 1 commit into from
May 21, 2024

Conversation

EspenAlbert
Copy link
Collaborator

@EspenAlbert EspenAlbert commented May 20, 2024

Description

Adds test for stream_instance SP10 stream_config.tier
The issue describes adding a new parameter, InstanceType support.
However, this is already supported with the stream_config.tier attribute.
I updated the 2nd test to include the configTier to validate that SP10 also works. (SP30 is the default tier)
Note that updating the tier is not supported in the API

Link to any related issue(s): CLOUDP-230986

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@EspenAlbert EspenAlbert marked this pull request as ready for review May 21, 2024 06:47
@EspenAlbert EspenAlbert requested a review from a team as a code owner May 21, 2024 06:47
@EspenAlbert EspenAlbert merged commit 75eb78f into master May 21, 2024
46 checks passed
@EspenAlbert EspenAlbert deleted the CLOUDP-230986_stream_instance_instance_type branch May 21, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants