fix: Removes update logic for the global_cluster_config resource. #2282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcosuma
changed the title
|
APIx bot: a message has been sent to Docs Slack channel |
lantoli
reviewed
May 17, 2024
internal/service/globalclusterconfig/resource_global_cluster_config_test.go
Show resolved
Hide resolved
lantoli
reviewed
May 17, 2024
lantoli
approved these changes
May 17, 2024
oarbusi
approved these changes
May 17, 2024
maastha
reviewed
May 17, 2024
| @@ -13,6 +13,7 @@ description: |- | |||
|
|
|||
| -> **NOTE:** Groups and projects are synonymous terms. You may find group_id in the official documentation. | |||
|
|
|||
| ~> **IMPORTANT:** A Global Cluster Configuration, once created, can only be deleted and never re-created again with the same data if not without the help of the Atlas UI. This is because the configuration and its related collection with shard key and indexes are managed separately and they would end up in an inconsistent state. [Read more about Global Cluster Configuration](https://www.mongodb.com/docs/atlas/global-clusters/) | |||
There was a problem hiding this comment.
Should we include about this in the release guide too?
Not sure if this should be considered a breaking change, I understand we are removing an incorrect behavior (just thinking out loud)
There was a problem hiding this comment.
It should not be considered a breaking change because it's a bug. I wasn't planning to put it in the release guide, but let me know otherwise
Co-authored-by: Sarah Simpers <[email protected]>
sarahsimpers
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
More info on https://jira.mongodb.org/browse/HELP-59447
tl;dr: updating the global_cluster_config resource leaves the collection and index in an inconsistent state because they are on the data plane side and they would remain unchanged.
That's also why the API does not have any PATCH endpoint.
Type of change:
Required Checklist:
Further comments