fix: CHARTS-10367 fix code sandbox examples #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristinamongo
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The published SDK release v3.3.0 has a breaking bug which raises an error on load of the SDK. The version is deprecated from npm. Though this shouldn't affect codesandbox examples we have since we have package-lock.json files, it looks like the package-lock.json file is ignored and it will pick up minor patched version automatically.
This PR Updates the sdk versions in the examples to the fixed version to resolve this issue.
Before
https://codesandbox.io/s/github/mongodb-js/charts-embed-sdk/tree/master/examples/charts/unauthenticated
After
https://codesandbox.io/s/github/mongodb-js/charts-embed-sdk/tree/fix/CHARTS-10367-code-sandbox-examples-not-working/examples/charts/unauthenticated
