Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added multiple models, along the lines of multiple languages. #40

Merged
merged 3 commits into from
Aug 2, 2024

Conversation

leokim-l
Copy link
Member

Several functions are called twice, output goes into multilingual dir and multimodel dir, present both within output and raw_results dirs. It is like a duplicated analysis, where multiple models are run for English only. This seems like a good first step.

Two hardcoded model name strings within ontogpt (its multilingual function) have to be edited in order for this to work. See

# English only many models
#TODO
# 1323 of ontogpt/cli.py and
# 15 of ontogpt/utils/multilingual.py
# have to be edited (get rid of hardcoded model!)

Multiple models are added here:

languages = ("en", "es", "nl", "it", "de")
models = ('gpt-4o', 'gpt-4') # Decide on list of models: Claude-Sonnet (Anthropic key),

… functions are called twice, output goes into multilingual and multimodel within output and raw_results dirs. Two hardcoded model names in ontogpt have to be edited in order for this to work
@leokim-l leokim-l marked this pull request as draft July 25, 2024 15:59
@leokim-l
Copy link
Member Author

Two hardcoded model name strings within ontogpt (its multilingual function) have to be edited in order for this to work. See

# English only many models
#TODO
# 1323 of ontogpt/cli.py and
# 15 of ontogpt/utils/multilingual.py
# have to be edited (get rid of hardcoded model!)

Probably done once monarch-initiative/ontogpt#415 is merged.

@leokim-l leokim-l marked this pull request as ready for review July 30, 2024 16:38
@leokim-l leokim-l merged commit d90eec6 into main Aug 2, 2024
1 check passed
@leokim-l leokim-l deleted the mult_models branch September 5, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants