Add selection animation

[sstarlung]

Add a flip animation like gmail for selection state. (issue #1232)

[moezbhatti]

Very clean solution!

A couple comments

• The checkmark is a little big, can you add some padding so that it has a size of 24dp?'
• I think it might look a little nicer with a vertical flip instead of horizontal
• The release-3.8 branch has a number of changes with regards to how avatars work, can you please rebase on top of that branch?

[sstarlung]

Thank you. I will modify and pull again.

Reply comments:

• The checkmark is a little big, can you add some padding so that it has a size of 24dp?'

I have tried padding in the beginning but it was too small to fit avatar icon (ic_shortcut_person.png). Current check img is supposed to align the size of avatar icon, like my screenshot in #1232. Maybe it shows different size on different phone?

• I think it might look a little nicer with a vertical flip instead of horizontal

small change. no problem.

• The release-3.8 branch has a number of changes with regards to how avatars work, can you please rebase on top of that branch?

Sure.

[moezbhatti]

You know what, I just took a look at the gmail app's implementation of this, and perhaps horizontal is actually the right call. It looks like there's a bit more going on in their implementation though, and I think that it makes it feel really nice and polished. In their implementation, the circle flips, but the checkmark itself does not. The checkmark animates in opacity and size, but never rotates

[sstarlung]

1. Gmail's animation is advanced and complicated version. I used a simple way to do the similar animation. I can take a moment to enhance it if you want.
2. I'm still struggling for release 3.8. I have no idea why exception for lang resource even I changed nothing.

java.lang.RuntimeException: Unable to start activity ComponentInfo{com.moez.QKSMS/com.moez.QKSMS.feature.main.MainActivity}: java.lang.IllegalArgumentException: Illegal Argument: Field not found: Recipient

[moezbhatti]

Ah, the branch contains new strings which haven't been translated yet. I'm not 100% sure why this would cause an issue for you since it looks like your language is set to English (CA) - but maybe try setting it to English (US) and see if that fixes the issue. Otherwise, I'll add the translated strings later today

[sstarlung]

This modification is ready on ver. 3.8.1. Which branch should I use?

[GeoZac]

This modification is ready on ver. 3.8.1. Which branch should I use?

AFAIK, master is bleeding edge