Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layer via composite shareKey #3415

Draft
wants to merge 30 commits into
base: federation-layers
Choose a base branch
from

Conversation

ScriptedAlchemy
Copy link
Member

@ScriptedAlchemy ScriptedAlchemy commented Dec 27, 2024

Description

Code Enhancements:

  • ContainerReferencePlugin.ts: Added handling for issuerLayer and context to improve module federation capabilities.
  • RemoteModule.ts: Enhanced the constructor and methods to support optional layer and context parameters, improving modularity and context handling. [1] [2] [3] [4]

Test Cases and Examples:

  • Added new test cases and configurations for layers in the packages/enhanced/test/configCases/layers/ directory, including components and webpack configurations to validate the layer functionality. [1] [2] [3] [4] [5] [6] [7] [8] [9]

These changes collectively enhance the project's modularity, configuration management, and testing capabilities, particularly in the context of module federation and layer handling.

Related Issue

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

Copy link

changeset-bot bot commented Dec 27, 2024

⚠️ No Changeset found

Latest commit: 419c1c8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ScriptedAlchemy ScriptedAlchemy changed the title Second attempt runtime layer Layer via composite shareKey Dec 28, 2024
…tion

- Consolidated common configuration for module federation across multiple layers.
- Introduced separate configurations for commonjs and module outputs.
- Updated shared dependencies and remotes for improved modularity and compatibility.
- Enhanced support for React with layer-specific configurations.
- Fixed missing semicolon in emptyComponent.js.
- Updated App.js to remove unnecessary blank line.
- Enhanced index.js test case formatting for better readability.
- Adjusted spacing in layered-react-loader.js for consistency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant