Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update package.json to support latest LTS version of Node.js #3376

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

steven-pribilinskiy
Copy link

@steven-pribilinskiy steven-pribilinskiy commented Dec 18, 2024

Description

Updated development requirements and contributing guidelines:

  • Changed Node.js and pnpm version constraints to use >= instead of ^ to allow newer compatible versions
  • Simplified branching strategy to only use main branch instead of main/canary

Addresses #3375

Although it is possible to use nvm/fnm, there is no convenient way to use both pnpm 8 and pnpm 9

Related Issue

N/A - Maintenance update

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have updated the documentation.
  • All new and existing tests passed.
  • I have updated the documentation.

Copy link

changeset-bot bot commented Dec 18, 2024

⚠️ No Changeset found

Latest commit: 60a072d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Dec 18, 2024

Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit 60a072d
🔍 Latest deploy log https://app.netlify.com/sites/module-federation-docs/deploys/67639bfb968b2000081e9c37
😎 Deploy Preview https://deploy-preview-3376--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@steven-pribilinskiy steven-pribilinskiy changed the title chore: update package.json to support latest LTS version of Node.js (#3375) chore: update package.json to support latest LTS version of Node.js #3375 Dec 18, 2024
@steven-pribilinskiy steven-pribilinskiy changed the title chore: update package.json to support latest LTS version of Node.js #3375 chore: update package.json to support latest LTS version of Node.js Dec 18, 2024
@@ -6,7 +6,7 @@ Thank you for your interest in contributing to Module Federation! Before startin

1. [Fork](https://help.github.com/articles/fork-a-repo/) the Module Federation repository into your own GitHub account.
2. [Clone](https://help.github.com/articles/cloning-a-repository/) the repository to your local machine.
3. Checkout a new branch from `main` or `canary`.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no canary branch

pnpm-lock.yaml Outdated

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too many changes here, probably pnpm 9 lockfile is not compatible with v8

@zhoushaw zhoushaw requested a review from 2heal1 December 19, 2024 04:06
@zhoushaw
Copy link
Collaborator

@2heal1 You can take care of this

@@ -2,8 +2,8 @@
"name": "module-federation",
"version": "0.0.0",
"engines": {
"node": "^18",
"pnpm": "^8.11.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we use corepack, should us exact pnpm version otherwise this can cause issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants