Added settings for caldav ssl verification #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #112 +/- ##
==========================================
- Coverage 93.47% 93.22% -0.26%
==========================================
Files 23 24 +1
Lines 1150 1166 +16
==========================================
+ Hits 1075 1087 +12
- Misses 75 79 +4
☔ View full report in Codecov by Sentry. |
tonioo
reviewed
May 4, 2023
modoboa_radicale/forms.py
Outdated
| (True, ugettext_lazy("Verify")), | ||
| (False, ugettext_lazy("Skip verification")), | ||
| ("path", ugettext_lazy("Provide CA bundle")) | ||
| ) |
There was a problem hiding this comment.
Bad indentation and I don't think it's a good idea to mix types here. Use either strings or integers for values.
There was a problem hiding this comment.
Like that ?
I don't see the bad indent though
There was a problem hiding this comment.
Yes, that's better.
And the last parenthesis should be moved to start of line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide users a way to disable ssl cert verification or provide a CA bundle as a trusted one. This enables user with self-signed certs to use the extension.