Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade esbuild to 0.20.x #2658

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

43081j
Copy link
Contributor

@43081j 43081j commented Mar 1, 2024

This just bumps esbuild to 0.20.x

it'll help de-dupe a lot of my dependency tree since many of our other dependencies are using esbuild 0.20.x 馃憖

Copy link

changeset-bot bot commented Mar 1, 2024

馃 Changeset detected

Latest commit: 9f15829

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
rollup-plugin-workbox Patch
@web/dev-server-esbuild Patch
@web/storybook-builder Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@43081j
Copy link
Contributor Author

43081j commented Mar 1, 2024

i think this is blocked until storybook also moves to esbuild 0.20.x

i have a PR here: storybookjs/storybook#26255

@bashmish
Copy link
Member

bashmish commented Mar 2, 2024

i think this is blocked until storybook also moves to esbuild 0.20.x

why do you think it's blocked?
in theory the storybook-builder is decoupled from storybook
not entirely, because the integration is done via a Connect middleware, but esbuild doesn't play a role there
so I think we can accept that storybook-builder has a newer esbuild version than the storybook core

@bashmish
Copy link
Member

bashmish commented Mar 3, 2024

I figured there will be another issue: chialab esbuild plugins used in the storybook-builder are on esbuild 0.19.x (e.g. esbuild-plugin-commonjs), those need compatibility. Can you raise a PR in their repo?

@43081j
Copy link
Contributor Author

43081j commented Mar 3, 2024

ah you are right, it isn't storybook, it is the commonjs plugin

basically, our Plugin type we import from esbuild is different than the Plugin the commonjs plugin exports (esbuild-plugin-commonjs)

so we need to upgrade that repo upstream first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants