wip

mmoll · Dec 13, 2024 · ec7a503 · ec7a503
1 parent d31baf5
commit ec7a503
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 7 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -40,14 +40,12 @@ jobs:
       matrix:
         os: [ubuntu-latest]
         php_version:
-          - 7.2
-          - 7.3
           - 7.4
           - 8.0
           - 8.1
           - 8.2
           - 8.3
-          - 8.4
+#          - 8.4
         dependencies_level:
           - --prefer-lowest
           - ""
@@ -94,7 +92,7 @@ jobs:
         run: vendor/bin/phpstan analyse --no-progress
       - name: Run psalm
         if: ${{ matrix.os != 'windows-latest' }}
-        run: vendor/bin/psalm --show-info=true
+        run: vendor/bin/psalm
       - name: Run phan
         if: ${{ matrix.os != 'windows-latest' }}
         run: vendor/bin/phan

diff --git a/MO4/Sniffs/Formatting/AlphabeticalUseStatementsSniff.php b/MO4/Sniffs/Formatting/AlphabeticalUseStatementsSniff.php
@@ -293,6 +293,7 @@ private function findNewDestination(File $phpcsFile, int $stackPtr, string $impo
         $tokens = $phpcsFile->getTokens();
 
         $line     = $tokens[$stackPtr]['line'];
+        /** @var int|bool $prevLine */
         $prevLine = false;
         $prevPtr  = $stackPtr;
 

diff --git a/MO4/Sniffs/Formatting/UnnecessaryNamespaceUsageSniff.php b/MO4/Sniffs/Formatting/UnnecessaryNamespaceUsageSniff.php
@@ -376,6 +376,7 @@ private function checkShorthandPossible(File $phpcsFile, array $useStatements, s
         if (true === $isDocBlock) {
             $tokens     = $phpcsFile->getTokens();
             $oldContent = $tokens[$startPtr]['content'];
+            /** @var string $newContent */
             $newContent = \str_replace($className, $replacement, $oldContent);
             $phpcsFile->fixer->replaceToken($startPtr, $newContent);
         } else {

diff --git a/composer.json b/composer.json
@@ -23,7 +23,7 @@
         "source": "https://github.com/mayflower/mo4-coding-standard"
     },
     "require": {
-        "php": "~7.2 || ~8.0",
+        "php": "~7.4 || ~8.0",
         "dealerdirect/phpcodesniffer-composer-installer": "~0.7 || ~1.0",
         "escapestudios/symfony2-coding-standard": "^3.10.0",
         "slevomat/coding-standard": "^8.14",
@@ -36,7 +36,7 @@
         "phpstan/phpstan-strict-rules": "^1.0",
         "phpunit/phpunit": "^7.5.20 || ^8.5.36 || ^9.6.15",
         "psalm/plugin-phpunit": "^0.18",
-        "vimeo/psalm": "^4.30"
+        "vimeo/psalm": "^5.26"
     },
     "config": {
         "allow-plugins": {

diff --git a/phpstan.neon b/phpstan.neon
@@ -5,6 +5,7 @@ parameters:
     paths:
        - %rootDir%/../../../MO4
        - %rootDir%/../../../tests
-    checkMissingIterableValueType: false
+    ignoreErrors:
+       - identifier: missingType.iterableValue
 includes:
     - vendor/phpstan/phpstan-strict-rules/rules.neon