WIP: Settings Page #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to develop Pulling branch of original repo into fork
…styled components
…heme) and decreased opacity to further match Momentum design intent
Settings page
dkozickis
suggested changes
Mar 6, 2019
…p, updated ReactModal.setAppElement, updated toggleModal action, moved @types to devDependencies
Updated per dikozickis comments on PR
|
@dkozickis updated per your comments |
|
@mmazzarolo Going to get back to work on this today, any further suggestions at this stage beyond following the Momentum design intent? |
|
@ONeill45 sorry, super busy lately 😬 |
|
@mmazzarolo No worries! I haven't gotten very far in that so far. Do you want the theme color toggle and hidden bookmark toggle to stay in the header or move to the settings modal? |
|
Yeah I was thinking the same... I guess it would be a good start to move them in the modal. What do you think? |
|
@mmazzarolo sounds good, i'll start with that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Settings modal is a WIP. At this stage one can open the modal using the gear icon in the header, and toggle it closed the same way.