Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct version comparison in Client.supports_fakeroot. #327

Conversation

sergey-serebryakov
Copy link
Contributor

@sergey-serebryakov sergey-serebryakov commented Aug 2, 2023

Fixing type error that was caused be comparing wrong types (mlcube_singularity.singularity_client.Version with semver.VersionInfo).

Fixing type error that was caused be comparing wrong types.
@sergey-serebryakov sergey-serebryakov requested a review from a team as a code owner August 2, 2023 06:16
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@sergey-serebryakov sergey-serebryakov merged commit c5f1193 into mlcommons:master Aug 2, 2023
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2023
@sergey-serebryakov sergey-serebryakov deleted the bugfix/supports-fakeroot branch August 2, 2023 06:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant