Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Trusted Publisher method for PyPi releases #324

Merged
merged 6 commits into from
Aug 4, 2023

Conversation

nathanw-mlc
Copy link
Member

@nathanw-mlc nathanw-mlc commented Jul 27, 2023

For publishing releases to PyPi, this PR switches from authenticating with user credentials to using the Trusted Publisher method.

Following this documentation for changes to the publish workflows.

Also normalized to kebab-case and updated some actions to move from Node12 to Node16.

Tested with TestPyPi in a forked repo.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2023

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@nathanw-mlc nathanw-mlc changed the title Switch to Trusted Publisher method for PyPi Switch to Trusted Publisher method for PyPi releases Jul 27, 2023
@nathanw-mlc nathanw-mlc marked this pull request as ready for review August 4, 2023 19:11
@nathanw-mlc nathanw-mlc requested a review from a team as a code owner August 4, 2023 19:11
Copy link
Contributor

@sergey-serebryakov sergey-serebryakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sergey-serebryakov sergey-serebryakov merged commit 3c759d0 into master Aug 4, 2023
3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 4, 2023
@nathanw-mlc nathanw-mlc deleted the pypi-trusted-publisher-implementation branch August 4, 2023 20:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants