Add functions for input-masked loss calculation and batching #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awni
reviewed
Nov 4, 2024
awni
reviewed
Nov 4, 2024
… an updated attempt to better sync with iterate_batches logic
chimezie
changed the title
…iterate_batches) by default.
Renamed the batch iteration function (iterate_delineated_batches -> iterate_completion_batches).
chimezie
added a commit
to chimezie/lm-evaluation-harness-mlx
that referenced
this pull request
Nov 10, 2024
Simplify by removing unnecessary imports and the unused chat templating method. Adjust tokens and batch handling to properly manage sequence lengths and masking using latest, related mlx_lm bits (ml-explore/mlx-examples#825).
|
Superseded by #1103 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for completion-only finetuning via functions for iterating over batching that also calculates input masks and a loss function using the masks and updates in (D/L)oRA tuner to use it w/
--mask-inputs(addressing/adding: #484, see: #1086)-- Updated to keep up with mlx(_lm) changes, etc.