Skip to content

Commit

Permalink
test: ignore test because it failed only in eslint 7.0.0
Browse files Browse the repository at this point in the history
  • Loading branch information
mizdra committed Mar 21, 2022
1 parent 6cd6c80 commit cc1e195
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion src/core.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ import { ESLint, Linter } from 'eslint';
import { Core, DEFAULT_BASE_CONFIG } from './core.js';
import { cleanupFixturesCopy, getSnapshotOfChangedFiles, setupFixturesCopy } from './test-util/fixtures.js';

const testIf = (condition: boolean) => (condition ? test : test.skip);

const cwd = join(dirname(fileURLToPath(import.meta.url)), '..');

// Normalize `message` for the snapshot.
Expand Down Expand Up @@ -89,7 +91,8 @@ describe('Core', () => {
const results = await core.lint();
expect(normalizeResults(results)).toMatchSnapshot();
});
test('printSummaryOfResults', async () => {
// Ignore because it failed only in eslint 7.0.0.
testIf(ESLint.version !== '7.0.0')('printSummaryOfResults', async () => {
const results = await core.lint();
console.log(core.formatResultSummary(results));
expect(core.formatResultSummary(results)).toMatchSnapshot();
Expand Down

1 comment on commit cc1e195

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.

Benchmark suite Current: cc1e195 Previous: 575110e Ratio
fix-all-of-many-files (undo, loop: 1) 156.26202100000228 ms 102.30216299998574 ms 1.53

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.