Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix] unable to login Docker #3040

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update Dockerfile
  • Loading branch information
Blipblopblopblop authored Sep 2, 2024
commit aa8945f6551ffe7d12b263a24f088b255f108b80
6 changes: 3 additions & 3 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -27,9 +27,9 @@ ENV PATH="$VIRTUAL_ENV/bin:$PATH"
# Install pip requirements
RUN pip3 install --no-cache-dir -r requirements.txt

# Set up config file and disable atomic by default
RUN python3 -c "import app; import app.utility.config_generator; app.utility.config_generator.ensure_local_config();"; \
sed -i '/\- atomic/d' conf/local.yml;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know why atomic was being disabled previously?

# Set up config file and dont disable atomic by default
Copy link
Contributor

@rfulwell rfulwell Nov 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: it should be "don't"
alternatively skip the negative part of the comment altogether:

Suggested change
# Set up config file and dont disable atomic by default
# Set up config file

RUN python3 -c "import app; import app.utility.config_generator; app.utility.config_generator.ensure_local_config();"


# Compile default sandcat agent binaries, which will download basic golang dependencies.

Loading