Add options for include directive #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhils
reviewed
Apr 26, 2024
Trimming the end of the contents means it often won't end in a newline and will become part of the new paragraph. This change adds a newline to contents after trimming the ends. Also fix :end-line: option to be absolute (not relative to :start-line:)
Co-authored-by: Maximilian Hils <[email protected]>
I somehow missed the last line of mhils comment earlier Co-authored-by: Maximilian Hils <[email protected]>
|
Thanks! This looks super nice now. Could you please add some basic tests for |
|
@mhils done, let me know if it's ok |
mhils
reviewed
May 13, 2024
mhils
approved these changes
May 16, 2024
|
@mhils thanks for finishing this up! Sorry I didn't get round to it earlier |
|
No worries and thanks again! :)
…On Thu, May 16, 2024 at 9:05 PM Frank Harkins ***@***.***> wrote:
@mhils <https://github.com/mhils> thanks for finishing this up! Sorry I
didn't get round to it earlier
—
Reply to this email directly, view it on GitHub
<#684 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHY2PXQFSDW54C3J3I4GWTZCT7NTAVCNFSM6AAAAABGQLOUWWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJVHE4TEMZZGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the
start-*andend-*options of the rstincludedirective. Closes #682.