test: fix test on host with ipv6 disabled #6941
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhils
reviewed
Jun 21, 2024
| @@ -9,6 +10,7 @@ def test_get_local_ip(): | |||
| local_ip.get_local_ip("invalid!") | |||
|
|
|||
|
|
|||
| @skip_no_ipv6 | |||
| def test_get_local_ip6(): | |||
| # should never error, but may return None depending on the host OS configuration. | |||
There was a problem hiding this comment.
The test is really here to ensure that we don't error, even in environments without IPv6. What error are you getting?
There was a problem hiding this comment.
On an ipv6 diabled host, the error message is as following:
"OSError: [Errno 97] Address family not supporterd by protocol"
I think skip_no_ipv6 is used to skip the test when detecting ipv6 is diabled on the host
There was a problem hiding this comment.
The test is correct, the underlying method needs to return None instead of raising. We don't want to skip the test.
There was a problem hiding this comment.
so do you mean the code itself is wrong? If so, i can fix the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix test failure on a host with ipv6 disabled
Checklist