Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase max header length #3785

Closed
wants to merge 1 commit into from
Closed

Increase max header length #3785

wants to merge 1 commit into from

Conversation

mprencipe
Copy link
Contributor

This is a kludge to help with #2936. My knowledge of Urwid is slim but it really doesn't seem to offer any tools for this problem.

Using weight = 1 for the header key/value columns would use the available space more efficiently and get you wrapping for both key and value. The downside would be that the key and value would no longer be adjacent.

@mhils
Copy link
Member

mhils commented Jan 19, 2020

Thanks @mprencipe! If I understand things correctly, this PR would mean that we always allocate 50 characters for header keys if we have a key that long, and make values wrap in the rest of the space. Is that correct?

@mprencipe
Copy link
Contributor Author

Yes, nothing special, as you described. Maybe the previous 30 character limit was a bit too little for modern monitors.

@mhils
Copy link
Member

mhils commented Feb 2, 2020

Hm. Assuming that header keys are generally smaller than header values, this would degrade the experience for everyone using a <100 col terminal window and we'll get a PR that reverts this in a couple of weeks. 😛 I'm not too much into urwid either, do we have any better approaches?

@mprencipe
Copy link
Contributor Author

Closing this as it's clearly not a good solution.

@mprencipe mprencipe closed this Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants