Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace split and ereg #20

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Replace split and ereg #20

wants to merge 2 commits into from

Conversation

neiltron
Copy link

This replaces instances of split with explode and instances of ereg with preg_match. Both split and explode were deprecated in PHP 5.3.0 and completely removed in PHP 7.0.0. There is another active pull request that does something similar but only replaces one instance of ereg.

@michaelperrin
Copy link

As we don't have any news from @mitcho , I think we should go for a fork including your PR, and name the plugin hookpress2 to submit it to the Wordpress plugins directory.
What do you think about it?

@neiltron
Copy link
Author

@michaelperrin You're welcome to take my pull request and start a fork. I'd prefer to not do that as I think it will get confusing for users. Seems like the best option would be for @mitcho to add someone to the repo and to the plugin on the plugin directory. That way he could have some help reviewing changes in the future. I think he may have taken a step back from open source development, which is totally understandable.

@mitcho
Copy link
Owner

mitcho commented Mar 16, 2017 via email

@michaelperrin
Copy link

That's cool then! I thought you weren't around @mitcho and that we wouldn't here from you at all. Keep us posted about this!

@Chaddeus
Copy link

I'm super interested in this project getting maintained again. Such a brilliant idea. Heck, you could probably charge like $49 for it and people would buy it. I just want to be able to trigger Zapier when a new member joins my WP site. :)

@corysimmons
Copy link

https://github.com/corysimmons/hookpress/archive/1.0.0.zip if anyone wants to composer install from this.

"repositories": [
  {
    "type": "package",
    "package": {
      "name": "corysimmons/hookpress",
      "type": "wordpress-plugin",
      "version": "1.0.0",
      "dist": {
        "type": "zip",
        "url": "https://github.com/corysimmons/hookpress/archive/1.0.0.zip"
      }
    }
  }
]

$ composer require corysimmons/hookpress

@neiltron
Copy link
Author

@mitcho bump 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants