-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace split
and ereg
#20
base: master
Are you sure you want to change the base?
Conversation
As we don't have any news from @mitcho , I think we should go for a fork including your PR, and name the plugin hookpress2 to submit it to the Wordpress plugins directory. |
@michaelperrin You're welcome to take my pull request and start a fork. I'd prefer to not do that as I think it will get confusing for users. Seems like the best option would be for @mitcho to add someone to the repo and to the plugin on the plugin directory. That way he could have some help reviewing changes in the future. I think he may have taken a step back from open source development, which is totally understandable. |
Hi -- I would strongly advise against this. I know I haven't been attentive but I'll find a new maintainer to take over.
2017/03/15 14:55、Michaël Perrin <[email protected]> のメッセージ:
… As we don't have any news from @mitcho , I think we should go for a fork including your PR, and name the plugin hookpress2 to submit it to the Wordpress plugins directory.
What do you think about it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
That's cool then! I thought you weren't around @mitcho and that we wouldn't here from you at all. Keep us posted about this! |
I'm super interested in this project getting maintained again. Such a brilliant idea. Heck, you could probably charge like $49 for it and people would buy it. I just want to be able to trigger Zapier when a new member joins my WP site. :) |
https://github.com/corysimmons/hookpress/archive/1.0.0.zip if anyone wants to composer install from this.
|
@mitcho bump 👀 |
This replaces instances of
split
withexplode
and instances ofereg
withpreg_match
. Bothsplit
andexplode
were deprecated in PHP 5.3.0 and completely removed in PHP 7.0.0. There is another active pull request that does something similar but only replaces one instance ofereg
.