Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement editor refactor from IOT/Alexa repository #3083

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ewpatton
Copy link
Member

This PR pulls a subset of the functionality from the IOT/Alexa repositories that refactors the YaFormEditor/YaBlocksEditor into separate Designer and Block editors that have shared functionality needed for a range of programmable entities.

Change-Id: I69831cfe43892dae14e7c85298ef3a7d65f4fc02

Change-Id: I69831cfe43892dae14e7c85298ef3a7d65f4fc02
@ewpatton
Copy link
Member Author

@SusanRatiLane I believe this covers all of the refactor necessary in core to support grouping design/code editors for entity types. In particular, take a look at the logic changes in DesignToolbar (you may want to compare with the alexa-editor branch) to see how the designer/block editor pairs are grouped together.

@SusanRatiLane
Copy link
Contributor

@SusanRatiLane I believe this covers all of the refactor necessary in core to support grouping design/code editors for entity types. In particular, take a look at the logic changes in DesignToolbar (you may want to compare with the alexa-editor branch) to see how the designer/block editor pairs are grouped together.

Does this include the performance refactors we discussed, or is that a separate set of changes?

@ewpatton
Copy link
Member Author

ewpatton commented Jan 3, 2024

@SusanRatiLane Those will come as a separate pull request, or possibly multiple, since there were 6 changes stacked on a single branch, and some are rather large.

# Conflicts:
#	appinventor/appengine/src/com/google/appinventor/client/editor/simple/components/utils/PropertiesUtil.java
#	appinventor/appengine/src/com/google/appinventor/client/editor/simple/palette/SimpleComponentDescriptor.java
#	appinventor/appengine/src/com/google/appinventor/client/editor/youngandroid/YaBlocksEditor.java
#	appinventor/appengine/src/com/google/appinventor/client/editor/youngandroid/YaFormEditor.java
#	appinventor/appengine/src/com/google/appinventor/client/editor/youngandroid/YaProjectEditor.java
@SusanRatiLane
Copy link
Contributor

@ewpatton This is now merged with master, but attempts to open a project throw an error that CircularProgress is an unknown component. I assume this means that something involving the port of Kodular components did not make it into the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants