Create models/foo.js exporting a ShimModelClass #2551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeAstapov
reviewed
Oct 5, 2023
| @@ -0,0 +1 @@ | |||
| export default class Foo {} | |||
There was a problem hiding this comment.
per 3cd81ef#r129177371 agree with @cah-brian-gantzler that this is not supposed to work as it's not Ember Data model
|
This #2556 is related and after looking into it, it appears a test is done too late. See the issue. |
|
Try rebasing now that #2569 is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is here to illustrate this issue of
discoverEmberDataModelswith ShimModelClassRun
pnpm --filter="basic-app" start && open http://localhost:4200to see the error in the consoleYou can also