make registry type configurable via dynamic variables #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LalatenduMohanty and/or @budhrg could you review this PR please? |
|
@johnkim76 as per this repository guideline [1] we need issue for each patch. I have created #95 for this PR. Please update the issue with some context and update the commit message too. [1] https://github.com/minishift/minishift-addons/blob/master/CONTRIBUTING.adoc#contributing-patches |
|
@johnkim76 Rest of the things looking fine to me. May be @eriknelson can a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the ASB addon will grab APB images from the upstream dockerhub repo/org. Adding the following as a dynamic variable allows the user to configure another registry type via '--addon-env'.