Translation updater: Add support for function call without parantheses #14574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note:
I haven't had a success in combining all of those so that the order matches the occurrences in the file. |
srifqi
added
@ Startup / Config / Util
Feature ✨
Zughy
added
the
Supported by core dev
|
Modified devtest/chest/chest.lua local S = minetest.get_translator("chest")
minetest.register_node("chest:chest", {
description = S"Chest" .. "\n" ..
"32 inventory slots",results in However, only "Chest" should be translated. |
This is a special case in Lua: function call with single parameter.
srifqi
force-pushed
the
tr_lua_special_function_call
branch
from
894541a
to
c56ce80
Compare
|
I moved matching strings for single parameter call before strings concatenations. This results in string order change:
I also rebased this PR. Ordering strings based on their occurrences in the file will be harder since there are text changes due to string concatenations after matching function call without parentheses and before matching function call with parentheses. |
appgurueu
reviewed
Apr 27, 2024
appgurueu
reviewed
Apr 27, 2024
grorp
added
the
Action / change needed
Co-authored-by: Lars Mueller <[email protected]>
appgurueu
removed
the
Action / change needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of the PR
This PR adds support for Lua function call without parentheses (single parameter function call).
How does the PR work?
This PR adds two patterns for Lua function call without parentheses, both for
"single/double-quote"and for[[multiline]].Does it resolve any reported issue?
This PR tries to fix #14494.
If not a bug fix, why is this PR needed? What usecases does it solve?
See the linked issue and https://www.lua.org/pil/5.html for informations about single argument call.
To do
This PR is Ready for Review.
How to test
S(and its variants) and without parentheses.