Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Pin py3.11 for MacOS latest / update publish version checks #1503

Merged
merged 15 commits into from
May 22, 2024

Conversation

felixdittrich92
Copy link
Contributor

@felixdittrich92 felixdittrich92 commented Mar 6, 2024

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.25%. Comparing base (0588750) to head (3f6f61d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1503      +/-   ##
==========================================
- Coverage   96.28%   96.25%   -0.04%     
==========================================
  Files         163      163              
  Lines        7706     7707       +1     
==========================================
- Hits         7420     7418       -2     
- Misses        286      289       +3     
Flag Coverage Δ
unittests 96.25% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felixdittrich92 felixdittrich92 changed the title ci-test [Fix] Pin py3.11 for MacOS latest / update publish version checks May 15, 2024
@felixdittrich92 felixdittrich92 added topic: ci Related to CI type: misc Miscellaneous labels May 15, 2024
@felixdittrich92
Copy link
Contributor Author

felixdittrich92 commented May 15, 2024

@odulcy-mindee We could apply this as temp fix because i think the fix in setup-python takes longer as expected :)

Maybe i will write some points in the repo wiki we should keep in mind --> https://github.com/mindee/doctr/wiki/TODO%E2%80%90Points

@felixdittrich92 felixdittrich92 marked this pull request as ready for review May 15, 2024 15:55
@felixdittrich92 felixdittrich92 added this to the 0.9.0 milestone May 15, 2024
@felixdittrich92 felixdittrich92 self-assigned this May 15, 2024
Copy link
Collaborator

@odulcy-mindee odulcy-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about pin macos version to macos-13 instead, as suggested here ?
actions/setup-python#855

@felixdittrich92
Copy link
Contributor Author

What about pin macos version to macos-13 instead, as suggested here ? actions/setup-python#855

@odulcy-mindee In this case we would need to update the required CI jobs

The repo says for python:

5 most popular major.minor versions

So i expect a fix for this in a future release that we can easily change this back, without updating our required CI jobs.

That's also the reason why i would prefer the py3.11 pin over the maco-13 pin :)

@odulcy-mindee
Copy link
Collaborator

@felixdittrich92 In this case we would need to update the required CI jobs

Aaaaaah, that's true :-(

Ok, let's keep it like that

@odulcy-mindee odulcy-mindee merged commit 9c92f5c into mindee:main May 22, 2024
79 of 81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: ci Related to CI type: misc Miscellaneous
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants