Cleanup #97
Open
Cleanup #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Djailla
commented
May 18, 2020
Djailla
commented
- Remove Python 2.7 support
- Fix Django deprecation warning
added 4 commits
May 15, 2020 17:14
url_filter/validators.py:22: RemovedInDjango40Warning: django.utils.translation.ungettext_lazy() is deprecated in favor of django.utils.translation.ngettext_lazy().
UTF-8 is default in Python3
Djailla
force-pushed
the
cleanup
branch
6 times, most recently
from
154a7ac
to
d88d62c
Compare
- Use pycqa flake8 version - Remove default --safe black option
|
Hello @miki725 I'm providing a review to cleanup django deprecation warning and trying to remove six dependency, but struggle understanding why CI fails for codecov, could you help me as I'm not an expert with Drone ci ? thanks |
|
Hello @miki725 how are you ? Any update on this PR ? |
|
No news for few month :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.