Django4 #112
Open
Django4 #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed querysets I was supplyin a queryset which was already distcint! And moreover I am using .distinct(field) in order to make a complex inetraction between url filters and Window functions work. Works a dream in fact except that url_filter was clobberig the necessary DISTINCT ON clause in my query. THis is where it happened and it was because it paid no heed to the existing status of the querie's distinct() setting. It neeed only apply distinct() if the caller has anot already applied on (not least as called knows what fields they need to distinguish on.
Simple spelling mistake. It's quiet not quite. Well a comix might say it's quite quiet ;-).
Sounds good. Thanks for the suggestion! Am on a learning curve here. And of course the only goal is that the stated one, that an existing DISTINCT clause be honored and not clobbered. Co-Authored-By: bernd-wechner <[email protected]>
|
@bernd-wechner I would like to know if you have an upcoming date to release support for Django 4 |
I don't do releases. Wondering if @miki725 is? |
|
Can we merge this PR ? |
|
Does anyone have this (and other improvements) forked. I think the maintainer is no longer committed to this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trivial changes for Django 4 compatibility. If these introduce Django 3 compatibility issues (which I doubt) then the change may need to be surrounded by a version check.