changed header/footer option for Chrome 120 #42
Conversation
|
Thanks! Would be nice to keep backwards compatibility with older Chrome versions. Can you keep the If you can keep it then please do, and add a comment saying something like |
Didn't even think about that, good call. Just adding the option seems to still work (as well as on Chromium 90), so I reverted + added it. |
|
Sorry, I confused you by posting on the original issue thread rather than this PR! Can you please add that comment to resume.py (not to this PR)? |
| @@ -128,6 +128,7 @@ def write_pdf(html: str, prefix: str = "resume", chrome: str = "") -> None: | |||
| "--no-sandbox", | |||
| "--headless", | |||
| "--print-to-pdf-no-header", | |||
| "--no-pdf-header-footer", | |||
There was a problem hiding this comment.
Keep both versions of this option for backwards compatibility, https://developer.chrome.com/docs/chromium/new-headless.
There was a problem hiding this comment.
I'm asking for a Python comment, i.e. a line starting with #, in the diff itself. Not a comment on github.com.
There was a problem hiding this comment.
Sure, sorry again for the confusion. Should be in the latest commit.
There was a problem hiding this comment.
All set. Thank you for the contribution!
Fixes #41