Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/strategy: Add failWithError support #224

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

emdemir
Copy link

@emdemir emdemir commented Feb 27, 2021

The failWithError option tells the strategy to not fail but pass instead
when authentication fails. This commit makes passport-jwt respect this setting.

The failWithError option tells the strategy to not fail but pass instead
when authentication fails. This commit makes passport-jwt respect this setting.
@canslaughter
Copy link

Passport already handles failWithError quite well and strategy.pass has nothing to do with it. This is just wrong.

@Outternet
Copy link

Could you elaborate on your idea, as I currently agree with the rest of the comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants