adding Promise handling to jwtFromRequest result, type checking on result and error handling for new functionality. #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…romise functionality in _jwtFromRequest
sbaker
changed the title
|
Hi, @mikenicholson I was wondering if you've had a chance to review this PR? |
|
+1 |
|
Hi, @mikenicholson I would really appreciate it if you can take a look at this PR. I need to be able to pass a Promise to |
thachp
approved these changes
Jul 4, 2021
|
Great point! Thanks! |
|
This is a good idea, I have adopted your implemetation in the major rewrite pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding Promise functionality in _jwtFromRequest result and adding unit tests to support new functionality
this fixes issue #186