Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Unification framework logger #4236

Merged
merged 10 commits into from
Dec 22, 2024
Merged

Conversation

czy88840616
Copy link
Member

@czy88840616 czy88840616 commented Dec 18, 2024

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

related: #3495

@czy88840616 czy88840616 changed the base branch from main to v4-next December 18, 2024 16:12
@czy88840616 czy88840616 added this to the 4.0 milestone Dec 18, 2024
@czy88840616 czy88840616 added the pr: new feature This PR adds a new API or behavior. label Dec 18, 2024
@czy88840616
Copy link
Member Author

czy88840616 commented Dec 22, 2024

@flyingcrp 日志调整,移除了特定框架下令人疑惑的 contextLoggerApplyLoggercontextLoggerFormat 配置

现在的规范

  • 组件和框架初始化,统一使用 coreLogger
  • 框架默认使用 appLogger 打印和 ctx 相关的日志,日志格式统一通过 midwayLogger 来指定,如果不希望使用 appLogger,则可以通过 setFrameworkLoggerName 方法改变这个默认日志

@czy88840616 czy88840616 added the pr: breaking change Existing sites may not build successfully in the new version. Description contains more details. label Dec 22, 2024
@czy88840616 czy88840616 merged commit 9632927 into v4-next Dec 22, 2024
4 checks passed
@czy88840616 czy88840616 deleted the unification_framework_logger branch December 22, 2024 04:02
@flyingcrp
Copy link
Contributor

是不是有v4的新文档版本还没有放出来。

@czy88840616
Copy link
Member Author

是不是有v4的新文档版本还没有放出来。

昨天在整,docusaurus 升 3 了,得花点时间。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: breaking change Existing sites may not build successfully in the new version. Description contains more details. pr: new feature This PR adds a new API or behavior.
Development

Successfully merging this pull request may close these issues.

2 participants