feat(grpc): initialize default metadata #4169
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waitingsong
force-pushed
the
grpc-method
branch
from
bfea8ad to
b5fe944
Compare
waitingsong
force-pushed
the
grpc-method
branch
from
b5fe944 to
437e92d
Compare
waitingsong
force-pushed
the
grpc-method
branch
from
9f5dc07 to
403ca31
Compare
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #4169 +/- ##
==========================================
+ Coverage 84.55% 85.20% +0.65%
==========================================
Files 491 519 +28
Lines 46778 50128 +3350
Branches 5601 5233 -368
==========================================
+ Hits 39551 42713 +3162
- Misses 7191 7389 +198
+ Partials 36 26 -10 ☔ View full report in Codecov by Sentry. |
waitingsong
force-pushed
the
grpc-method
branch
2 times, most recently
from
8412bae to
b7ca3d3
Compare
|
奇怪，啥参数没改，单测就报 |
waitingsong
force-pushed
the
grpc-method
branch
3 times, most recently
from
288b3dd to
0662d18
Compare
|
终于过了…… |
czy88840616
reviewed
Nov 11, 2024
| let genericFunctionName; | ||
| switch (genericFunctionSelector) { | ||
| case 0: | ||
| options.metadata.set('rpc.method.type', 'unary'); |
There was a problem hiding this comment.
这里的 metadata，不能是写死的，要么做到外部可覆盖，要么就搞一个私有的 key 好了，比如叫 midway.rpc.method.type啥的
| @@ -1,6 +1,7 @@ | |||
| import { join } from 'path'; | |||
|
|
|||
| export const grpcServer = { | |||
| url: 'localhost:6568', | |||
waitingsong
force-pushed
the
grpc-method
branch
from
da0032d to
4354f91
Compare
|
一折腾又炸了～ |
waitingsong
force-pushed
the
grpc-method
branch
3 times, most recently
from
18399b7 to
b35590d
Compare
|
win 下面 jest 调试真麻烦…… |
|
可以搞个gitpod |
czy88840616
reviewed
Nov 13, 2024
| } else { | ||
| clientOptions.metadata = new Metadata(); | ||
| } | ||
| clientOptions.metadata.set('rpc.definition', definition); |
There was a problem hiding this comment.
这里有问题吧，如果 clientOptions.metadata 有值，就被覆盖了吧。
这里是不是这样就行了
const meta = new Metadata();
meta.set('xx', xx);
clientOptions.metadata = clientOptions.metadata ? meta.merge(clientOptions.metadata) : meta;
waitingsong
force-pushed
the
grpc-method
branch
2 times, most recently
from
caadbcf to
75e17e6
Compare
czy88840616
reviewed
Nov 16, 2024
| @@ -71,6 +71,17 @@ export class GRPCClients extends Map { | |||
| connectionService[methodName] = ( | |||
| clientOptions: IClientOptions = {} | |||
| ) => { | |||
| const meta = new Metadata(); | |||
| meta.set('rpc.definition', definition); | |||
There was a problem hiding this comment.
话说传递这些有啥用？客户端自己应该都知道吧，不然没法解析出来找到服务了。另外可能也会有性能和安全性问题 🤔
waitingsong
force-pushed
the
grpc-method
branch
from
75e17e6 to
5922751
Compare
waitingsong
force-pushed
the
grpc-method
branch
from
5922751 to
9c770a2
Compare
waitingsong
force-pushed
the
grpc-method
branch
from
9c770a2 to
63e7dc1
Compare
key: rpc.method.type value: unary|server|client
waitingsong
force-pushed
the
grpc-method
branch
from
63e7dc1 to
57fa626
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
请求中添加 Meta 信息：