-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: double format issue #63
Open
ghostoy
wants to merge
2
commits into
midwayjs:main
Choose a base branch
from
ghostoy:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
我先把测试处理下。 |
@ghostoy 可以先 rebase 一下 master |
`splat` of `winston` takes care of message formatting. No need to format the message on `@midwayjs/logger` side. Fixed midwayjs#62
@czy88840616 rebase过了 |
@ghostoy 貌似ci挂了 。 |
@czy88840616 应该好了,再跑下ci试试 |
应该是有影响原来的 case 了 |
现在test里期望 还有下面这些输出在原有实现中是没有定义和测试的:
这个PR我暂时不打算继续改了,对于%的输出实在不好兼容现有的测试用例。 |
logger.info('first', 'second') 是兼容原有 egg-logger 的需求,和 winston 不一定很兼容(后续大概率会抛弃 winston,自己来实现)。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
splat
ofwinston
takes care of message formatting. No need to formatthe message on
@midwayjs/logger
side.Fixed #62