Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: Rime.Weasel version 0.16.0.0 #153641

Merged

Conversation

SpecterShell
Copy link
Contributor

@SpecterShell SpecterShell commented May 15, 2024

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label May 15, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label May 15, 2024
@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@SpecterShell SpecterShell changed the title Update: Rime.Weasel version 0.16.0.0 New version: Rime.Weasel version 0.16.0.0 May 15, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed Manifest-Validation-Error Manifest validation failed Needs-Author-Feedback This needs a response from the author. labels May 15, 2024
@wingetbot wingetbot added New-Manifest Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels May 15, 2024
@stephengillie
Copy link
Collaborator

Hi @SpecterShell,

This PR's version number 0.16.0.0 has 4 parameters (sets of numbers between dots - major, minor, etc), which is greater than the current manifest's version 0.14.3, which has 3 parameters.

Does this PR's version number exactly match the version reported in the Apps & features Settings page? (Feel free to attach a screenshot.)

(Automated response - build 881)

@stephengillie
Copy link
Collaborator

stephengillie commented May 15, 2024

Hi @SpecterShell,

This manifest removes Apps and Features entries that are present in previous PR versions. These entries should be added to this version, to maintain version matching, and prevent the 'upgrade always available' situation with this package.

(Automated response - build 881.)

Edit: This removes the previous version, so no worreis about removing the entries.

PS C:\ManVal> Find-WinGetPackage Rime.Weasel

Name         Id          Version Source
----         --          ------- ------
小狼毫輸入法 Rime.Weasel 0.14.3  winget

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Author-Feedback This needs a response from the author. Version-Parameter-Mismatch This manifest's package version has a different number of parameters than the newest in repo. labels May 15, 2024
@SpecterShell
Copy link
Contributor Author

Hi @SpecterShell,

This PR's version number 0.16.0.0 has 4 parameters (sets of numbers between dots - major, minor, etc), which is greater than the current manifest's version 0.14.3, which has 3 parameters.

Does this PR's version number exactly match the version reported in the Apps & features Settings page? (Feel free to attach a screenshot.)

(Automated response - build 881)

image

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels May 16, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label May 16, 2024
@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels May 16, 2024
@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels May 16, 2024
@stephengillie stephengillie merged commit 87e6f29 into microsoft:master May 16, 2024
8 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Attention This work item needs to be reviewed by a member of the core team. label May 16, 2024
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

1 similar comment
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@SpecterShell SpecterShell deleted the Rime.Weasel-0.16.0.0-21219C2E branch May 16, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR New-Manifest Publish-Pipeline-Succeeded Validation-Completed Validation passed Version-Parameter-Mismatch This manifest's package version has a different number of parameters than the newest in repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Update Request]: Rime.Weasel [Update Request]: Rime.Weasel
3 participants