Respect stackframe deemphasize in getTopStackFrame #211855
Open
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OccasionalDebugger
force-pushed
the
improvement/respect-deemphasize-in-top
branch
2 times, most recently
from
6b9c17a
to
66775b8
Compare
OccasionalDebugger
force-pushed
the
improvement/respect-deemphasize-in-top
branch
from
66775b8
to
45ae3b3
Compare
|
Does js-debug set this? Haven't tried it but it looks right. cc @connor4312 |
connor4312
reviewed
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #211854
This PR adds consideration of the value
'deemphasize'on aStackFrameto the logic for selecting the top stack frame of a given thread. This brings the selection logic in line with the display logic used by theCallStackView, where a frame with the presentation hintdeemphasizeis treated the same as a frame whose source has such a presentation hint.