fix: add selection to next find match (CTRD + D) not working with Regex Find Mode (#107090) #211550
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #107090 .
Solved by passing
isRegex
flag fromfindController
toMultiCursorSession
as much like thewholeWord
andmatchCase
flags.Added unit test to specifically test this issue. While writing the unit test, I identified another potential issue: while adding selection to next find match using the find controller, the selection range that was there, previous to the change of focus to the find input box, is not released. That is the reason I had to add the
[1, 1, 1, 1]
range to the expectedselections
array in the unit test assertion. Since this issue has a different root cause, I am opening a new issue to tackle this separately.I appreciate a lot your feedback in advance,